-
Notifications
You must be signed in to change notification settings - Fork 264
added priority based preemption to priority plugin #895
added priority based preemption to priority plugin #895
Conversation
Priority plugin now adds preemptable function which makes preemptee a victim iff job priority of the preemptee is strictly lower than job priority of the preemptor. This is consistent with default behavior of the standard kubernetes scheduler: if a Pod cannot be scheduled, the scheduler tries to preempt (evict) lower priority Pods to make scheduling of the pending Pod possible (see https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/). Closes kubernetes-retired#894
Hi @mateuszlitwin. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adjusted log level from 3 to 4 inside all preemptable functions for consistency, to make build pass and to not spam too many logs. |
/assign @k82cn |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, mateuszlitwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Priority plugin now adds preemptable function which makes preemptee a victim if and only if job priority of the preemptee is strictly lower than job priority of the preemptor.
This is consistent with default behavior of the standard kubernetes scheduler: if a Pod cannot be scheduled, the scheduler tries to preempt (evict) lower priority Pods to make scheduling of the pending Pod possible (see https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/).
To disable this functionality use
enablePreemptable: false
in thepriority
plugin configuration.Closes #894
Which issue(s) this PR fixes :
Fixes #894
Special notes for your reviewer:
Release note: