Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added priority based preemption to priority plugin #570

Merged
merged 1 commit into from
Dec 11, 2019
Merged

added priority based preemption to priority plugin #570

merged 1 commit into from
Dec 11, 2019

Conversation

mateuszlitwin
Copy link
Contributor

Cherry-picking from kubernetes-retired/kube-batch#895.

@volcano-sh-bot
Copy link
Contributor

Welcome @mateuszlitwin!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2019
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 27, 2019
@TravisBuddy
Copy link

Hey @mateuszlitwin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0d585500-1175-11ea-b8ff-d5ab8a371226

@k82cn
Copy link
Member

k82cn commented Nov 28, 2019

/approve

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@k82cn
Copy link
Member

k82cn commented Nov 28, 2019

That'll be great to have this feature in volcano :)

@k82cn
Copy link
Member

k82cn commented Nov 28, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@TravisBuddy
Copy link

Hey @mateuszlitwin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f3388ab0-11a0-11ea-b428-cb0bccf60dd8

@TravisBuddy
Copy link

Hey @mateuszlitwin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 640d1240-11c1-11ea-b428-cb0bccf60dd8

@k82cn
Copy link
Member

k82cn commented Nov 30, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@TravisBuddy
Copy link

Hey @mateuszlitwin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d3d2e910-153b-11ea-a5d4-6b7b0fca08ad

@TravisBuddy
Copy link

Hey @mateuszlitwin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 460fcb40-1ae3-11ea-b9ce-6f43500ed087

@TravisBuddy
Copy link

Travis tests have failed

Hey @mateuszlitwin,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e870dfe0-1b70-11ea-bf43-1b2acb1c8aac

@TravisBuddy
Copy link

Hey @mateuszlitwin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 81c888d0-1b78-11ea-bf43-1b2acb1c8aac

@mateuszlitwin mateuszlitwin marked this pull request as ready for review December 10, 2019 18:20
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2019
@mateuszlitwin
Copy link
Contributor Author

@k82cn can you approve again? I had to add small change to e2e tests to pass.

@k82cn
Copy link
Member

k82cn commented Dec 11, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, mateuszlitwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 1b5a1b1 into volcano-sh:master Dec 11, 2019
@mateuszlitwin mateuszlitwin deleted the mlitwin-priority-based-preemption branch December 11, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mateuszlitwin @volcano-sh-bot @TravisBuddy @k82cn