This repository has been archived by the owner on Jul 28, 2019. It is now read-only.
Fix "DIND_K8S_BIN_DIR: unbound variable" error when running fixed scripts #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Sorry for this bug, the problem was missed by CI :( /lgtm |
|
/approve |
k8s-ci-robot
added
the
approved
ElvinEfendi
force-pushed
the
fix-fixed-scripts
branch
from
7ee3fe3 to
91b890a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, ivan4th, jellonek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@ElvinEfendi , @ivan4th - Apologies for the regression. @ElvinEfendi, thanks for taking care of this!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #247 we started to see
DIND_K8S_BIN_DIR: unbound variableerror when running afixedscript. This PR is fixing that.