Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store ewma stats per backend #3467

Merged
merged 2 commits into from
Nov 26, 2018
Merged

store ewma stats per backend #3467

merged 2 commits into from
Nov 26, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
Currently we store EWMA stats about upstream peers in a single dictionary regardless of app/backend. This PR refactors the code so that EWMA stats are part of EWMA balancer instance for a given backend.

Without this change when app A's upstream peers change, we would lose stats for app B's upstream peers as well. This PR is fixing that issue.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2018
@ElvinEfendi ElvinEfendi force-pushed the ewma-stats-per-backend branch from 616e49c to f81f061 Compare November 26, 2018 12:59
@ElvinEfendi ElvinEfendi force-pushed the ewma-stats-per-backend branch from 42a1180 to c03ac37 Compare November 26, 2018 13:20
@ElvinEfendi ElvinEfendi changed the title [WIP] store ewma stats per backend store ewma stats per backend Nov 26, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2018
@ElvinEfendi
Copy link
Member Author

CI is broken, I made kubernetes-retired/kubeadm-dind-cluster#258 to fix it

ElvinEfendi
ElvinEfendi commented Nov 26, 2018
View reviewed changes
test/e2e/up.sh Outdated
@@ -31,7 +31,7 @@ touch ${HOME}/.kube/config
export KUBECONFIG=${HOME}/.kube/config

echo "starting Kubernetes cluster..."
curl -Lo $DIR/dind-cluster-v1.11.sh https://raw.githubusercontent.com/kubernetes-sigs/kubeadm-dind-cluster/master/fixed/dind-cluster-v1.11.sh && \
curl -Lo $DIR/dind-cluster-v1.11.sh https://raw.githubusercontent.com/ElvinEfendi/kubeadm-dind-cluster/fix-fixed-scripts/fixed/dind-cluster-v1.11.sh && \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to fix the CI, I'll revert once kubernetes-retired/kubeadm-dind-cluster#258 is merged

@ElvinEfendi
Copy link
Member Author

/assign @aledbf

@codecov-io
Copy link

Codecov Report

Merging #3467 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3467   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files          77       77           
  Lines        5899     5899           
=======================================
  Hits         2812     2812           
  Misses       2708     2708           
  Partials      379      379

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b65b85c...9996687. Read the comment docs.

@ElvinEfendi ElvinEfendi force-pushed the ewma-stats-per-backend branch from 9996687 to c03ac37 Compare November 26, 2018 20:04
@aledbf
Copy link
Member

aledbf commented Nov 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 118fdad into kubernetes:master Nov 26, 2018
@ElvinEfendi ElvinEfendi deleted the ewma-stats-per-backend branch December 3, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayt wayt wayt approved these changes

@antoineco antoineco Awaiting requested review from antoineco

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ElvinEfendi @codecov-io @aledbf @k8s-ci-robot @wayt