Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update livenessprobe image version from 2.1.0 to 2.2.0 #756

Merged

Conversation

mowangdk
Copy link
Contributor

Is this a bug fix or adding new feature?
Fix #749

What is this PR about? / Why do we need it?
Upgrade livenessprobe to patch memory leak

What testing is done?
helm install in k8s cluster

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2021
@coveralls
Copy link

coveralls commented Feb 21, 2021

Pull Request Test Coverage Report for Build 1629

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.656%

Totals Coverage Status
Change from base Build 1626: 0.0%
Covered Lines: 1736
Relevant Lines: 2126

💛 - Coveralls

@@ -21,7 +21,7 @@ sidecars:
tag: "v3.0.3"
livenessProbeImage:
repository: k8s.gcr.io/sig-storage/livenessprobe
tag: "v2.1.0"
tag: "v2.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the chart version as well? Otherwise github actions fails.

@mowangdk mowangdk force-pushed the upgrade_livenessprobe_version branch from c807089 to cc03798 Compare February 23, 2021 02:33
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2021
@@ -2,7 +2,7 @@ apiVersion: v1
appVersion: "0.9.0"
name: aws-ebs-csi-driver
description: A Helm chart for AWS EBS CSI Driver
version: 0.9.8
version: 0.9.9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayberk PTAL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged an earlier PR, could you update it to 0.9.10?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mowangdk
Copy link
Contributor Author

/retest

@mowangdk mowangdk force-pushed the upgrade_livenessprobe_version branch from cc03798 to cfe43f2 Compare February 24, 2021 02:15
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2021
@mowangdk mowangdk force-pushed the upgrade_livenessprobe_version branch from cfe43f2 to 4d783dd Compare February 24, 2021 07:30
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2021
@ayberk
Copy link
Contributor

ayberk commented Feb 25, 2021

/lgtm
/approve

Thanks a lot!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@ayberk
Copy link
Contributor

ayberk commented Feb 25, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit fc70a38 into kubernetes-sigs:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade livenessprobe to patch memory leak
4 participants