-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a document separator for storageclass template file #762
Conversation
Welcome @nvnmandadhi! |
Hi @nvnmandadhi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1625
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. just encountered this as well.
/lgtm I'm going to merge multiple chart changes and update the version. Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk, georambo, nvnmandadhi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sounds good, thank you @ayberk, I'm looking to work on more issues, could you suggest a task please? |
I'd keep an eye on good-first-issues :) Appreciate the help! |
Is this a bug fix or adding new feature?
not a new feature
What is this PR about? / Why do we need it?
adds a document separator for storageclass template file
What testing is done?
tested using helm template