Added e2e test for driver version upgrade #213

jqmichael · 2020-07-16T02:55:42Z

Is this a bug fix or adding new feature?
feature

What is this PR about? / Why do we need it?
Added e2e test for driver version upgrade

What testing is done?

go test ./test/e2e/ -v -kubeconfig=$HOME/.kube/config --region=us-west-2 --report-dir="./results" -ginkgo.focus="\[restart\]|\[upgrade\]" --cluster-name="eks-11602" --file-system-id fs-b6654c1c

k8s-ci-robot · 2020-07-16T02:55:49Z

Hi @jqmichael. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Jeffwan · 2020-07-16T18:35:06Z

/ok-to-test

jqmichael · 2020-07-16T18:54:20Z

/retest

wongma7 · 2020-07-17T00:02:16Z

pkg/driver/efs_watch_dog.go

@@ -71,7 +71,7 @@ dns_name_suffix = sc2s.sgov.gov
 [mount-watchdog]
 enabled = true
 poll_interval_sec = 1
-unmount_grace_period_sec = 30
+unmount_grace_period_sec = 5


What are the implications of changing this? I'm OK with changing it for a test, but it seems wrong to change it for everyone.

wongma7 · 2020-07-17T00:08:42Z

test/e2e/e2e.go

+	return makePVCWithPV(pv, namespace, name)
+}
+
+func makePVCWithPV(pv *v1.PersistentVolume, namespace, name string) (*v1.PersistentVolumeClaim, *v1.PersistentVolume) {


This function name is confusing. "With" could mean "make a PVC along with a PV".

I suggest separating the binding code below (setting volumeName of a given PVC and claimRef of a given PV) to a separate function.

wongma7 · 2020-07-17T00:10:52Z

test/e2e/e2e.go

+			validatePodVolumeAccessible(f, pod)
+		})
+
+		ginkgo.It("[efs] [github] [tls] [upgrade] should continue reading/writing after the driver pod is upgraded from stable version", func() {


What is the meaning of the new tags? It's not necessary to have an [efs] tag because everything is already tagged "[efs-csi] EFS CSI"

wongma7 · 2020-07-17T00:11:34Z

test/e2e/e2e.go

+	command := fmt.Sprintf("touch /mnt/volume1/%s-%s && trap exit TERM; while true; do sleep 1; done", f.Namespace.Name, time.Now().Format(time.RFC3339))
+
+	isPrivileged := false
+	var nodeSelector map[string]string


nodeSelector is not set correctly, something got lost in the refactoring.

It seems like nodeSelector was never set correctly?

Yeah I never set it: https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/test/e2e/e2e.go#L225 so with 3 nodes we had a 1/3 chance of actually running the test as intended.

I wouldn't use nodeSelector anyway ,I would rather just set pod.spec.Nodename

wongma7 · 2020-07-17T00:15:03Z

test/e2e/e2e.go

+	framework.ExpectNoError(err, "deleting driver pod")
+}
+
+func createPvPvcWithPv(f *framework.Framework, pv *v1.PersistentVolume) (*v1.PersistentVolume, *v1.PersistentVolumeClaim) {


Sorry but I hate this function name

wongma7 · 2020-07-17T00:16:51Z

test/e2e/e2e.go

+	return createEFSPVPVC(c, namespace, pvc, pv)
+}
+
+func createEFSPVPVC(c clientset.Interface, namespace string, pvc *v1.PersistentVolumeClaim, pv *v1.PersistentVolume) (*v1.PersistentVolumeClaim, *v1.PersistentVolume, error) {


createEFSPVCPV vs createEFSPVPVC?

k8s-ci-robot · 2020-07-20T18:34:24Z

@jqmichael: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wongma7 · 2020-07-23T21:12:15Z

test/e2e/e2e.go

+	ginkgo.By("Updating to the EFS CSI driver")
+	currentEfsDriver, err := daemonSetClient.Get("efs-csi-node", metav1.GetOptions{})
+	driverUpgradeTo.ResourceVersion = currentEfsDriver.ResourceVersion
+	_, err = daemonSetClient.Update(driverUpgradeTo)


Need to wait for daemonset to be totally replaced. Or at least the driver pod on the node we care about

fejta-bot · 2020-10-21T21:16:27Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-11-20T22:00:03Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2020-12-20T22:44:28Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-12-20T22:44:35Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wongma7 · 2021-01-07T02:52:21Z

I might pick this up depending on whether it's easier to manually do the test or fix it : p

k8s-ci-robot · 2021-01-07T02:52:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jqmichael

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jqmichael]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2021-01-07T02:52:33Z

@jqmichael: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-aws-efs-csi-driver-e2e	`a376379`	link	`/test pull-aws-efs-csi-driver-e2e`
pull-aws-efs-csi-driver-verify	`a376379`	link	`/test pull-aws-efs-csi-driver-verify`
pull-aws-efs-csi-driver-unit	`a376379`	link	`/test pull-aws-efs-csi-driver-unit`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wongma7 · 2021-01-07T22:23:14Z

/lifecycle frozen

k8s-triage-robot · 2021-08-17T22:22:11Z

The lifecycle/frozen label can not be applied to PRs.

This bot removes lifecycle/frozen from PRs because:

Commenting /lifecycle frozen on a PR has not worked since March 2021
PRs that remain open for >150 days are unlikely to be easily rebased

You can:

Rebase this PR and attempt to get it merged
Close this PR with /close

Please send feedback to sig-contributor-experience at kubernetes/community.

/remove-lifecycle frozen

k8s-triage-robot · 2021-11-16T00:19:37Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2021-12-16T01:14:34Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2022-01-15T01:24:35Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-01-15T01:24:46Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 16, 2020

k8s-ci-robot requested review from jsafrane and nckturner July 16, 2020 02:55

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 16, 2020

jqmichael force-pushed the upgradeE2eTest branch from ea7fec0 to 0b57ae6 Compare July 16, 2020 06:08

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2020

jqmichael force-pushed the upgradeE2eTest branch 2 times, most recently from df0b742 to a9c0dd8 Compare July 16, 2020 18:46

jqmichael force-pushed the upgradeE2eTest branch from a9c0dd8 to fd76b8c Compare July 16, 2020 23:40

Added e2e test for driver version upgrade

a376379

jqmichael force-pushed the upgradeE2eTest branch from fd76b8c to a376379 Compare July 16, 2020 23:46

wongma7 reviewed Jul 17, 2020

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2020

wongma7 reviewed Jul 23, 2020

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 20, 2020

k8s-ci-robot closed this Dec 20, 2020

wongma7 reopened this Jan 7, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021

wongma7 mentioned this pull request Jan 7, 2021

change config dir location #286

Merged

k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 7, 2021

wongma7 mentioned this pull request Feb 4, 2021

helm chart: ensure that upgrades do not delete csidriver resource #324

Merged

wongma7 mentioned this pull request Apr 29, 2021

CI upgrade test #432

Closed

k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Aug 17, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 16, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 16, 2021

k8s-ci-robot closed this Jan 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added e2e test for driver version upgrade #213

Added e2e test for driver version upgrade #213

jqmichael commented Jul 16, 2020

k8s-ci-robot commented Jul 16, 2020

Jeffwan commented Jul 16, 2020

jqmichael commented Jul 16, 2020

wongma7 Jul 17, 2020

wongma7 Jul 17, 2020

wongma7 Jul 17, 2020

wongma7 Jul 17, 2020

wongma7 Jul 17, 2020

wongma7 Jul 17, 2020

wongma7 Jul 17, 2020

wongma7 Jul 17, 2020

k8s-ci-robot commented Jul 20, 2020

wongma7 Jul 23, 2020

fejta-bot commented Oct 21, 2020

fejta-bot commented Nov 20, 2020

fejta-bot commented Dec 20, 2020

k8s-ci-robot commented Dec 20, 2020

wongma7 commented Jan 7, 2021

k8s-ci-robot commented Jan 7, 2021

k8s-ci-robot commented Jan 7, 2021

wongma7 commented Jan 7, 2021

k8s-triage-robot commented Aug 17, 2021

k8s-triage-robot commented Nov 16, 2021

k8s-triage-robot commented Dec 16, 2021

k8s-triage-robot commented Jan 15, 2022

k8s-ci-robot commented Jan 15, 2022

Added e2e test for driver version upgrade #213

Added e2e test for driver version upgrade #213

Conversation

jqmichael commented Jul 16, 2020

k8s-ci-robot commented Jul 16, 2020

Jeffwan commented Jul 16, 2020

jqmichael commented Jul 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 20, 2020

Choose a reason for hiding this comment

fejta-bot commented Oct 21, 2020

fejta-bot commented Nov 20, 2020

fejta-bot commented Dec 20, 2020

k8s-ci-robot commented Dec 20, 2020

wongma7 commented Jan 7, 2021

k8s-ci-robot commented Jan 7, 2021

k8s-ci-robot commented Jan 7, 2021

wongma7 commented Jan 7, 2021

k8s-triage-robot commented Aug 17, 2021

k8s-triage-robot commented Nov 16, 2021

k8s-triage-robot commented Dec 16, 2021

k8s-triage-robot commented Jan 15, 2022

k8s-ci-robot commented Jan 15, 2022