helm chart: ensure that upgrades do not delete csidriver resource

[steved]

Is this a bug fix or adding new feature?

Bug fix.

What is this PR about? / Why do we need it?

Upgrades of the Helm chart from a version pre-hook addition (52315a5) to one with the hook will delete the csidriver object without creating another in its place.

What testing is done?

$ git checkout v0.3.0
$ cd helm/
$ helm install . --generate-name
...
$ kubectl get csidriver
NAME              CREATED AT
efs.csi.aws.com   2021-02-03T23:56:36Z

$ git checkout v1.1.0
$ helm upgrade chart-1612396594 .
$ kubectl get csidriver
No resources found

$ git checkout <this branch>
$ helm upgrade chart-1612396594 .
$ kubectl get csidriver
NAME              CREATED AT
efs.csi.aws.com   2021-02-04T00:24:51Z

[k8s-ci-robot]

Welcome @steved!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @steved. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wongma7]

/ok-to-test

I want to try this out, I think this was missed because I use helm install --upgrade not helm upgrade? Also, our CI does not test the upgrade scenario which is a known issue. #213

[wongma7]

/lgtm
/approve

thanks again

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steved, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wongma7]

/test pull-aws-efs-csi-driver-e2e