-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --default-target-type flag #2840
Conversation
Codecov ReportBase: 54.07% // Head: 54.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
==========================================
- Coverage 54.07% 54.01% -0.06%
==========================================
Files 144 144
Lines 8301 8312 +11
==========================================
+ Hits 4489 4490 +1
- Misses 3484 3494 +10
Partials 328 328
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
One question would be how to document the default value of annotations whose default value depend on flags. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: default value in the configurations.md
Changes look good to me.
/lgtm Thanks a lot for the contribution |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fc462d5
to
851a7d0
Compare
/lgtm |
Issue
Closes #2690
Description
Adds a
--default-target-type
flag which sets the default target type of both Services and Ingresses.The desired target type of an ALB or NLB is almost always determined by the the cluster's CNI. If a cluster's CNI uses ENIs (like AWS VPC CNI does) then the desired target type is
ip
. If a cluster's CNI uses masquerading, then the desired target type isinstance
.When a cluster's CNI uses ENIs, it is a burden to require each workload's
Ingress
andService
resources to include an LBC-specific annotation in order to function.This allows clusters with ENI-based CNIs to set the default target type to
ip
, allowingIngress
andService
resources to work correctly without having to set a target-type annotation on each one.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯