Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add johngmyers as reviewer #2999

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

johngmyers
Copy link
Contributor

Adds johngmyers as reviewer

Per the requirements:

[x] member for at least 3 months
[x] Primary reviewer for at least 5 PRs to the codebase
#2950, #2942, #2425, #2963, #2988,
#2986
[x] Reviewed or merged at least 20 substantial PRs to the codebase
#2950, #2942, #2880, #2866, #2453,
#2435, #2433, #2425, #2442, #2500,
#2443, #2963, #2735, #2881, #2840,
#2987, #2988, #2992, #2993, #2955,
#2990,
[x] Knowledgeable about the codebase
[ ] Sponsored by a subproject approver
[ ] With no objections from other approvers
[x] Done through PR to update the OWNERS file
[x] May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 54.01% // Head: 54.01% // No change to project coverage 👍

Coverage data is based on head (75572e1) compared to base (fecb1af).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2999   +/-   ##
=======================================
  Coverage   54.01%   54.01%           
=======================================
  Files         144      144           
  Lines        8312     8312           
=======================================
  Hits         4490     4490           
  Misses       3494     3494           
  Partials      328      328           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kishorj
Copy link
Collaborator

kishorj commented Jan 25, 2023

/lgtm

Thanks for your contributions.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3b1f07a into kubernetes-sigs:main Jan 25, 2023
@johngmyers johngmyers deleted the reviewer branch January 25, 2023 01:01
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants