Start migration to leases for leader election #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Codecov ReportBase: 54.01% // Head: 54.01% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2993 +/- ##
=======================================
Coverage 54.01% 54.01%
=======================================
Files 144 144
Lines 8312 8312
=======================================
Hits 4490 4490
Misses 3494 3494
Partials 328 328
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
k8s-ci-robot
added
size/M
johngmyers
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
kishorj
added
the
tide/merge-method-squash
kishorj
approved these changes
Jan 23, 2023
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
a7i
pushed a commit
to a7i/aws-load-balancer-controller
that referenced
this pull request
Apr 7, 2023
This was referenced Apr 14, 2023
12 tasks
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Sep 11, 2024
Controller-runtime has been updated and doesn't support configmaps for the leader election anymore. Upstream PR: kubernetes-sigs/aws-load-balancer-controller#2993
alebedev87
added a commit
to alebedev87/aws-load-balancer-operator
that referenced
this pull request
Dec 6, 2024
Controller-runtime has been updated and doesn't support configmaps for the leader election anymore. Upstream PR: kubernetes-sigs/aws-load-balancer-controller#2993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Configures leader election to use both ConfigMaps and Leases.
Migration to leases is long overdue. The most recent version of controller-runtime appears to not support using only ConfigMaps.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯