Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for NLB target-group-attributes to enable unhealthy target connection draining #3577

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Add example for NLB target-group-attributes to enable unhealthy target connection draining #3577

merged 2 commits into from
Feb 27, 2024

Conversation

jukie
Copy link
Contributor

@jukie jukie commented Feb 14, 2024

Issue

Description

Adds example for an additional target group attribute that's already supported

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @jukie!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jukie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2024
@oliviassss
Copy link
Collaborator

/assign @shraddhabang

shraddhabang
shraddhabang approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@shraddhabang shraddhabang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2024
@oliviassss oliviassss added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 22, 2024
@oliviassss
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jukie, oliviassss, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@jukie
Copy link
Contributor Author

jukie commented Feb 22, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

@jukie: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliviassss oliviassss removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 22, 2024
@oliviassss
Copy link
Collaborator

The unit test and e2e test failing should not be related to this PR, but it's not allowing me to force merge the PR.

@jukie
Copy link
Contributor Author

jukie commented Feb 23, 2024 •
edited
Loading

@oliviassss was that due to the failed tests and merge rules? It looks like the e2e test just timed out and a retest may help and the unit test also may have been a one-off?

@oliviassss
Copy link
Collaborator

@jukie, yeah usually for doc change these tests may not be necessary, but let's see if retest could pass.
/retest

@oliviassss oliviassss added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 27, 2024
@oliviassss oliviassss merged commit b63a294 into kubernetes-sigs:main Feb 27, 2024
7 of 9 checks passed
@jukie jukie deleted the docs/example-for-unhealthy-target-draining branch February 28, 2024 19:29
shraddhabang pushed a commit to shraddhabang/aws-load-balancer-controller that referenced this pull request Mar 20, 2024
@jukie @shraddhabang
Add example for NLB target-group-attributes to enable unhealthy targe…
ca11ce5 
…t connection draining (kubernetes-sigs#3577)

* Add example annotation for NLB unhealthy target connection draining

* Add emtpyline back in
M00nF1sh pushed a commit that referenced this pull request Mar 22, 2024
@shraddhabang @oliviassss
@alebedev87 @the-technat @jukie @xdu31 @haouc @alex-berger
Release v2.7.2 - Cherry picked the commits from main (#3620)
61e0135 
* fix log level in listener manager and tagging manager (#3573)

* bump up controller-gen version and update manifests (#3580)

* docs: ingress subnets annotation - clarify locale differences (#3579)

* feat: allowed ACM cert discovery to filter on CA ARNs (#3565) (#3591)

* Add example for NLB target-group-attributes to enable unhealthy target connection draining (#3577)

* Add example annotation for NLB unhealthy target connection draining

* Add emtpyline back in

* fix: ca-filter causing expontentially more api-calls (#3608)

due to missing cache

* Repo controlled build go version (#3598)

* update go version to mitigate CVE (#3615)

* Adding support for Availability Zone Affinity (#3470)

Fixes #3431

Signed-off-by: Alex Berger <alex-berger@gmx.ch>

* Update golang.org/protobuf version to fix CVE-2024-24786 (#3618)

* Add a note to recommend to use compatible chart and image versions

* Update golang.org/protobuf version to fix CVE-2024-24786

---------

Signed-off-by: Alex Berger <alex-berger@gmx.ch>
Co-authored-by: Olivia Song <sonyingy@amazon.com>
Co-authored-by: Andrey Lebedev <alebedev87@gmail.com>
Co-authored-by: Nathanael Liechti <technat@technat.ch>
Co-authored-by: Isaac Wilson <10012479+jukie@users.noreply.github.com>
Co-authored-by: Nathanael Liechti <nathanael.liechti@post.ch>
Co-authored-by: Jason Du <jasonxdu@amazon.com>
Co-authored-by: Hao Zhou <haouc@users.noreply.github.com>
Co-authored-by: Alexander Berger <alex-berger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shraddhabang shraddhabang shraddhabang approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@kishorj kishorj Awaiting requested review from kishorj

Assignees

@shraddhabang shraddhabang

@oliviassss oliviassss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jukie @k8s-ci-robot @oliviassss @shraddhabang