Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add conditions for the reconcile delete workflow #1905

Merged
merged 1 commit into from
Sep 25, 2020
Merged

🌱 Add conditions for the reconcile delete workflow #1905

merged 1 commit into from
Sep 25, 2020

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Adding conditions for the reconcile delete workflow

Which issue(s) this PR fixes:
Fixes #1867

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2020
@fabriziopandini
Copy link
Member Author

/hold
for CAPI version v0.3.9

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 1, 2020
@fabriziopandini fabriziopandini force-pushed the reconcile-delete-conditions branch from 032577d to ee2d3d9 Compare September 14, 2020 13:34
@fabriziopandini fabriziopandini changed the title [WIP] 🌱 Add conditions for the reconcile delete workflow 🌱 Add conditions for the reconcile delete workflow Sep 14, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2020
@fabriziopandini
Copy link
Member Author

/hold cancel
rebase on top of CAPI v0.3.9

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2020
@randomvariable
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@gab-satchi
Copy link
Member

thanks @fabriziopandini

/lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2020
@randomvariable
Copy link
Member

@fabriziopandini needs a rebase unfortunately.

@fabriziopandini fabriziopandini force-pushed the reconcile-delete-conditions branch from ea0798c to 15749e0 Compare September 24, 2020 14:01
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 24, 2020
@fabriziopandini
Copy link
Member Author

@randomvariable no problem!
done

@gab-satchi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2020
@randomvariable
Copy link
Member

@fabriziopandini oof, looks like some nil pointers in the tests

@fabriziopandini fabriziopandini force-pushed the reconcile-delete-conditions branch from 15749e0 to 7e646eb Compare September 25, 2020 09:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2020
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8b229b9 into kubernetes-sigs:master Sep 25, 2020
@randomvariable randomvariable mentioned this pull request Sep 25, 2020
Merged
19 tasks
@fabriziopandini fabriziopandini deleted the reconcile-delete-conditions branch September 30, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@randomvariable randomvariable

@gab-satchi gab-satchi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add conditions for deletion workflows
4 participants
@fabriziopandini @randomvariable @k8s-ci-robot @gab-satchi