-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add externalManagedControlPlane Status to fix node drain under EKS #1992
🐛 Add externalManagedControlPlane Status to fix node drain under EKS #1992
Conversation
Welcome @dthorsen! |
Hi @dthorsen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test /cc @alexeldeib @CecileRobertMichon |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it: When using the AWSManagedControlPlane, if you delete a Machine resource it does not gracefully cordon and drain the associated Node. The fix for this in CAPI is to have the managed control plane provider set the
externalManagedControlPlane: true
value in its status to signal to cluster-api that the control plane Nodes are not visible in the cluster.Related to: kubernetes-sigs/cluster-api#3631