-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 externalManagedControlPlane status field should have been optional #1994
🐛 externalManagedControlPlane status field should have been optional #1994
Conversation
Hi @dthorsen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0a4370c
to
7b0ad0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @randomvariable
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
7b0ad0a
to
0b534c0
Compare
0b534c0
to
1dcb333
Compare
@randomvariable Got the tests to pass now |
/lgtm |
What this PR does / why we need it: The recently added
externalManagedControlPlane
in #1992 should have been optional, not required to be eligible for release in a minor version.