Allow runing github action with ok-to-test
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github actions are not running for non-member contributors, unless a repo admin presses the "Approve and Run" button. The problem with that is that PRs are getting merged with no verification, causing leak of bugs into the codebase. This PR copies a github action from the cluster-api repo, that approve running the github action by adding the `ok-to-test` label. Source: https://github.com/kubernetes-sigs/cluster-api/blob/613a37e0183e818403ff086165bd619393b34178/.github/workflows/pr-gh-workflow-approve.yaml Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
davidvossel
reviewed
Aug 30, 2023
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel, nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yes, tested it. /unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/override unit_test wrong requirement name. See kubernetes/test-infra#30577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Github actions are not running for non-member contributors, unless a repo admin presses the "Approve and Run" button. The problem with that is that PRs are getting merged with no verification, causing leak of bugs into the codebase.
This PR copies a github action from the cluster-api repo, that approve running the github action by adding the
ok-to-testlabel.Source: https://github.com/kubernetes-sigs/cluster-api/blob/613a37e0183e818403ff086165bd619393b34178/.github/workflows/pr-gh-workflow-approve.yaml
Release notes: