Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CAPK required test name #30577

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix CAPK required test name #30577

merged 1 commit into from
Aug 31, 2023

Conversation

nunnatsa
Copy link
Contributor

@nunnatsa nunnatsa commented Aug 31, 2023 •
edited
Loading

Since the unit test in the cluster-api-provider-kubevirt is running with github action matrix, the existing unit_test name for the required test is wrong, and should be unit_test (ubuntu-latest).

This PR fixes issue caused by #30564

@nunnatsa
Fix CAPK required test name
673538a 
Since the unit test in the cluster-api-provider-kubevirt is running with
github action matrix, the existing `unit_test` name for the required
test is wrong, and should be `unit_test (ubuntu-latest)`.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 31, 2023
@nunnatsa nunnatsa mentioned this pull request Aug 31, 2023
Merged
@matthyx
Copy link
Contributor

matthyx commented Aug 31, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2023
@jbpratt
Copy link
Contributor

jbpratt commented Aug 31, 2023

/approve

@xmcqueen
Copy link
Contributor

/lgtm

@xmcqueen
Copy link
Contributor

/assign @cblecker

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jbpratt, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 779552c into kubernetes:master Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

@nunnatsa: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

Since the unit test in the cluster-api-provider-kubevirt is running with github action matrix, the existing unit_test name for the required test is wrong, and should be unit_test (ubuntu-latest).

This PR fixes issue caused by #30564

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa deleted the capk-fix branch August 31, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker approved these changes

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@cblecker cblecker

@matthyx matthyx

@xmcqueen xmcqueen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nunnatsa @matthyx @jbpratt @xmcqueen @k8s-ci-robot @cblecker