Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document removal of kube-dns support in kubeadm #4026

Closed
fabriziopandini opened this issue Dec 16, 2020 · 10 comments · Fixed by #4402
Closed

Document removal of kube-dns support in kubeadm #4026

fabriziopandini opened this issue Dec 16, 2020 · 10 comments · Fixed by #4402
Assignees
Labels
area/bootstrap Issues or PRs related to bootstrap providers area/control-plane Issues or PRs related to control-plane lifecycle management good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@fabriziopandini
Copy link
Member

Kubeadm is going to drop support for kube-dns in version 1.21 (xref kubernetes/kubeadm#1943).

This should not be a problem for CABPK/KCP users, given that almost all of them should be using CoreDNS, however, we should consider if/how to issue a note to our user in case someone is still using kube-dns by twicking KubeadmConfig.Cluster configuration.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 16, 2020
@fabriziopandini
Copy link
Member Author

/remove-kind feature
/kind documentation
/area bootstrap
/area control-plane

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Dec 16, 2020
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/bootstrap Issues or PRs related to bootstrap providers area/control-plane Issues or PRs related to control-plane lifecycle management and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 16, 2020
@furkatgofurov7
Copy link
Member

@fabriziopandini hi! Has someone started working on this? I am happy to help if no one is interested. (Suggestions/pointers where to start looking and where notes must be put would be awesome to have).

@vincepri
Copy link
Member

vincepri commented Feb 8, 2021

/good-first-issue
/help
/priority backlog
/milestone v0.4.x

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help
/priority backlog
/milestone v0.4.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 8, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v0.4.0, v0.4.x Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 8, 2021
@sgirem463
Copy link
Contributor

@fabriziopandini Hi, I am a new contributor, would like to work on this. Would appreciate your suggestions/pointers.

@sgirem463
Copy link
Contributor

/assign @sgirem463

@fabriziopandini
Copy link
Member Author

What about adding a note in https://cluster-api.sigs.k8s.io/tasks/kubeadm-control-plane.html#kubeconfig-management. Something like

<aside class="note warning">
<h1>Warning</h1>
KCP support only CoreDNS as a DNS server; also kube-dns support has been removed by kubeadm in v1.21.
</aside>

@CecileRobertMichon CecileRobertMichon modified the milestones: v0.4.x, v0.4 Mar 22, 2021
@sgirem463
Copy link
Contributor

@fabriziopandini I will work on this

@sgirem463
Copy link
Contributor

@fabriziopandini @vincepri
I have made changes to the document source, the diffs are:

ALLANs-MBP:tasks alue$
ALLANs-MBP:tasks alue$ git diff
diff --git a/docs/book/src/tasks/kubeadm-control-plane.md b/docs/book/src/tasks/kubeadm-control-plane.md
index 50b606cf5..d24ab4f3c 100644
--- a/docs/book/src/tasks/kubeadm-control-plane.md
+++ b/docs/book/src/tasks/kubeadm-control-plane.md
@@ -2,6 +2,14 @@

Using the Kubeadm control plane type to manage a control plane provides several ways to upgrade control plane machines.

+


+
+

Warning


+
+KCP support only CoreDNS as a DNS server; also kube-dns support has been removed by kubeadm in v1.21.
+
+
+

Kubeconfig management

KCP will generate and manage the admin Kubeconfig for clusters. The client certificate for the admin user is created
ALLANs-MBP:tasks alue$
ALLANs-MBP:tasks alue$

I am not sure what tests should be done for document updates.
I did "make serve-book" to serve a api book locally, the screenshot of the page is:

Screen Shot 2021-03-29 at 11 38 27 PM

Is there anything else I should do before pulling a PR?

@sbueringer
Copy link
Member

@sgirem463 I think it's totally fine to just open a PR to propose this change.

sgirem463 added a commit to sgirem463/cluster-api that referenced this issue Mar 31, 2021
…ubernetes-sigs#4026'

minor update to correct a spelling issue

changed to: KubeadmControlPlane is solely supporting CoreDNS as a DNS server at this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Issues or PRs related to bootstrap providers area/control-plane Issues or PRs related to control-plane lifecycle management good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants