-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate and remove kube-dns support in kubeadm #1943
Comments
Maybe we can print the deprecate info around here https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/addons/dns/dns.go#L135 |
i think that is a good location, yes. |
@neolit123 - if kube-dns is being deprecated, we should do it too. But If @kubernetes/sig-network-misc didn't I think we should wait |
/cc @bowei |
technically, kubeadm is an opinionated deployer that can decide what addons to pick as their best practice cluster. at the same time kubeadm allows skipping the DNS addon, and allowing the user to pick their own. |
@rajansandeep @chrisohaver i think we can proceed with this PR for preserving the replica count kubernetes/kubernetes#85837 but we might need the refactor of not redeploying the CoreDNS/kube-dns completely from scratch, instead:
also me and @rosti discussed today that before that we should probably file the PR to deprecate kube-dns in 1.18 and stop maintaining it. |
Indeed. It's becoming rather tricky to maintain a couple of possible DNS addons. Especially when one of them is not getting as much user attention than the other. |
So shall we file a PR to deprecate kube-dns now? |
yes, it was decided to file the deprecation but also gather feedback if someone is still using it with kubeadm. |
note: we haven't updated the kube-dns version in kubeadm since 1.14.13 (20 Sept, 2018). https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/constants/constants.go |
sent notification to k-dev: LGTM/approved the deprecation PR: |
As soon as this becomes deprecated, documentation that mentions the application called IMO: it's enough to open an issue in k/website and leave the actual rewording and localization and localization to SIG Docs. |
that may still be confusing for other reasons
$ kubectl cluster-info
Kubernetes master is running at https://127.0.0.1:32832
KubeDNS is running at
https://127.0.0.1:32832/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy
To further debug and diagnose cluster problems, use 'kubectl cluster-info
dump'.
…On Fri, Jan 24, 2020 at 1:44 AM Tim Bannister ***@***.***> wrote:
As soon as this becomes deprecated, documentation that mentions the
*application* called kube-dns should change to make that detail clear.
AIUI kube-dns the application will remain even past the deprecation of
kube-dns the addon.
IMO: it's enough to open an issue in k/website
<https://github.com/kubernetes/website> and leave the actual rewording
and localization and localization to SIG Docs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1943?email_source=notifications&email_token=AAHADKZJUHCDTZGJYG7SWWTQ7K2AZA5CNFSM4JSMODOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ2H73I#issuecomment-578060269>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK4Y5XMCWT5D76NJSQLQ7K2AZANCNFSM4JSMODOA>
.
|
The service is named "kube-dns" and changing that would probably break
various things ...
On Fri, Jan 24, 2020 at 5:47 PM Benjamin Elder <bentheelder@google.com>
wrote:
… that may still be confusing for other reasons
$ kubectl cluster-info
Kubernetes master is running at https://127.0.0.1:32832
KubeDNS is running at
https://127.0.0.1:32832/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy
To further debug and diagnose cluster problems, use 'kubectl cluster-info
dump'.
On Fri, Jan 24, 2020 at 1:44 AM Tim Bannister ***@***.***>
wrote:
> As soon as this becomes deprecated, documentation that mentions the
> *application* called kube-dns should change to make that detail clear.
> AIUI kube-dns the application will remain even past the deprecation of
> kube-dns the addon.
>
> IMO: it's enough to open an issue in k/website
> <https://github.com/kubernetes/website> and leave the actual rewording
> and localization and localization to SIG Docs.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#1943?email_source=notifications&email_token=AAHADKZJUHCDTZGJYG7SWWTQ7K2AZA5CNFSM4JSMODOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ2H73I#issuecomment-578060269>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHADK4Y5XMCWT5D76NJSQLQ7K2AZANCNFSM4JSMODOA>
> .
>
|
originally SIG Network wanted to add the CoreDNS service as
true. |
+1 for adding a core DNS service + deprecate the kube-DNS one, but this is really up to SIG-network |
I wonder if we can update doesn't seem super important, but I could certainly see users being confused about "KubeDNS is running at" when we're not using kubedns... |
Has #1943 (comment) been raised to SIG Network? |
cc @johnbelamaric @chrisohaver
|
I have been referring to the cluster service discovery DNS service in Kubernetes as "Cluster DNS", to distinguish it from other DNS services in the K8s equation... (Upstream DNS, Node Local Caching DNS). |
I don't think we should change the service name, as pointed out it will break stuff (which is why we didn't do it before). The "KubeDNS" I believe comes from an annotation, that could be change, I would think. It could vary based on which DNS provider is installed. Or it could just read "Cluster DNS" as Chris suggests. |
I'd like to help with this. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
@neolit123, I can handle the actions for 1.21
/assign |
thank you @rajansandeep ! |
this is a proposal to deprecate the kube-dns deployment with the release of 1.18 and remove the code for it in 1.21.
CoreDNS has been the default since 1.11 (if i recall correctly) and the kube-dns support is something we should decouple from kubeadm.
We haven't updated the kube-dns version in kubeadm since 2018.
ideally and long term, the users should be able to skip the DNS server deployment completely and install a custom one to their liking, either manually or via a "addon installer" of sorts.
actions for 1.18:
mark kube-dns as deprecated in kubeadm stdout:
assigned: @SataQiu
PR: kubeadm: kube-dns is deprecated and will not be supported in a future version kubernetes#86574
add deprecation notes in docs
assigned: @neolit123
PRs kubeadm: add notes about deprecating kube-dns usage in 1.18 website#18851
actions for 1.21:
clean kube-dns from the kubeadm codebase
assigned: @rajansandeep
PRs [kubeadm]: Remove the deprecated kube-dns as an option in kubeadm kubernetes#99646
clean any mentions of kube-dns + kubeadm in the k/website docs
assigned: @rajansandeep
PRs deprecate and remove kube-dns support in kubeadm #1943
UPDATE
sent notification to k-dev:
https://groups.google.com/d/msg/kubernetes-dev/m8suvuNBtcU/BglNo6tUAAAJ
The text was updated successfully, but these errors were encountered: