Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [release-1.8] kcp: consider all machines for setting .status.version #11306

Merged
merged 1 commit into from
Oct 21, 2024
Merged

🐛 [release-1.8] kcp: consider all machines for setting .status.version #11306

merged 1 commit into from
Oct 21, 2024

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2024
@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-8
  • /test pull-cluster-api-e2e-blocking-release-1-8
  • /test pull-cluster-api-e2e-conformance-ci-latest-release-1-8
  • /test pull-cluster-api-e2e-conformance-release-1-8
  • /test pull-cluster-api-e2e-mink8s-release-1-8
  • /test pull-cluster-api-e2e-release-1-8
  • /test pull-cluster-api-e2e-upgrade-1-30-1-31-release-1-8
  • /test pull-cluster-api-test-mink8s-release-1-8
  • /test pull-cluster-api-test-release-1-8
  • /test pull-cluster-api-verify-release-1-8

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-8
  • pull-cluster-api-build-release-1-8
  • pull-cluster-api-e2e-blocking-release-1-8
  • pull-cluster-api-test-release-1-8
  • pull-cluster-api-verify-release-1-8

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 733298029918d8c9861f515e6a5f526f51779768

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@fabriziopandini
Copy link
Member

/lgtm

@chrischdi
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4f37883 into kubernetes-sigs:release-1.8 Oct 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-gaston g-gaston Awaiting requested review from g-gaston

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @k8s-ci-robot @sbueringer @fabriziopandini