-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add CAPI Provider Operator CAEP #3833
📖 Add CAPI Provider Operator CAEP #3833
Conversation
44d3306
to
469e342
Compare
@fabriziopandini Feel free to take another look and make changes or add comments where ever you see fit. Since I'm out next week, if you think we are in a good place to get feedback, feel free to remove the WIP label. Thanks. |
469e342
to
9924826
Compare
c2a1261
to
0d09e7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the feedback from the review, I've updated the CAEP with the suggestions.
I'm still thinking about the need or options instead of using SecretName for the variables.
0d09e7c
to
13571e0
Compare
4fb9180
to
d963724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies if I duplicated comments from the google doc, I lost access and wasn't able to review it again
54e2a3a
to
a4d573a
Compare
@wfernandes When you're ready for final review, and approvals, please close out all the open discussions and squash commits |
lgtm overall |
bf937bc
to
75d439d
Compare
uh... |
/lgtm |
/milestone v0.4.0 |
75d439d
to
f3a9ddd
Compare
@fabriziopandini Please lgtm it again. I had to fix a markdown linking issue for /cc @CecileRobertMichon @vincepri @detiber also looking for a final approval (if y'all approve of course 😄 ) |
f3a9ddd
to
2955368
Compare
/test pull-cluster-api-test-main |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For future reference, I've created this hackmd doc that has a some of the story break down to accomplish this work. |
What this PR does / why we need it:
This PR adds the management cluster operator CAEP proposal to Cluster API for review.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3427
/kind proposal