-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Enable Webhooks and CertManager for CAPI operator #4132
🌱 Enable Webhooks and CertManager for CAPI operator #4132
Conversation
@wfernandes: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Domain is cluster.x-k8s.io
kubebuilder create api --group operator --version v1alpha4 --kind CoreProvider
kubebuilder create api --group operator --version v1alpha4 --kind BootstrapProvider Created Resources, not controllers
kubebuilder create api --group operator --version v1alpha4 --kind ControlPlaneProvider Created Resources, not controllers
kubebuilder create api --group operator --version v1alpha4 --kind InfrastructureProvider Created Resources, not controllers
Fix some module imports. Will be cleaned up in future PRs.
Removes the ginkgo BeforeSuite pattern
e5690a1
to
4b98eee
Compare
Adds CRDs to providers category
4b98eee
to
da91042
Compare
@wfernandes: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/milestone v0.4.0 |
@JoelSpeed @alexander-demichev do we still need this PR? |
I think it can be closed, rebasing it will be harder than opening a new one. |
as per comment above |
@fabriziopandini: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4131
Ref #3833
/area api
/area operator