⚠ leaderelection: use 'leases' as default resource lock object

[joelanford]

Update the default resource lock from configmapsleases to leases.

The previous default (since v0.7.0) was configmapsleases, which is the migration step from configmaps to leases. Since the default was configmapsleases for over a year, spanning five minor releases, any actively maintained operators are very likely to have a released version that uses configmapsleases. Therefore defaulting to leases now should be safe.

Any operators currently on a version <0.7.0 should migrate from configmaps to leases via configmapsleases.

• If an operator is currently on version <v0.7.0, it is hardcoded to using configmaps
• If an operator is currently in the range v0.7.0 to a version prior to this PR merging, it is configurable, but defaulted to configmapsleases.
• If an operator is using a version of controller-runtime containing this PR, it is configurable but defaulted to leases.

Operators currently using configmaps should:

1. Release a version (A) of their operator that uses controller-runtime v0.7.0+ (if jumping directly to a version of controller-runtime containing this PR, you should explicitly set configmapsleases when configuring leader election in this version)
2. Release a subsequent version (B) of their operator that uses a version of controller-runtime containing this PR (or if not bumping, you should explicitly set leases when configuring leader election in this version)
3. Ensure operators upgrade through A before getting to B.

See kubernetes/kubernetes#107454 (This PR moves controller-runtime from step x+1 to x+2)

Signed-off-by: Joe Lanford joe.lanford@gmail.com

[joelanford]

/test pull-controller-runtime-test-master

[joelanford]

/test pull-controller-runtime-test-master

[vincepri]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [joelanford,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment