Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance tests should allow an error state in Route Parent status #1135

Closed
robscott opened this issue Apr 29, 2022 · 0 comments · Fixed by #1152
Closed

Conformance tests should allow an error state in Route Parent status #1135

robscott opened this issue Apr 29, 2022 · 0 comments · Fixed by #1152
Labels
area/conformance

Comments

@robscott
Copy link
Member

Currently we have several tests with a TODO to allow implementations to actually provide an error in Route parent status if they are able to (example).

I think there are 2 valid ways to represent this:

  1. len(Route.Status.Parents) == 0
  2. len(Route.Status.Parents) == 1 and the first entry has an Accepted condition set to false

Our tests currently only allow the first one, but they should allow both.
@robscott robscott mentioned this issue Apr 29, 2022
Merged
@mikemorris mikemorris mentioned this issue May 4, 2022
Closed
11 tasks
howardjohn added a commit to howardjohn/gateway-api that referenced this issue May 9, 2022
@howardjohn
conformance: allow error status in Route
1aeacae 
Fixes kubernetes-sigs#1135

This changes tests to assert their is either no parent at all, or a
non-accepted parent (indicating an error message, presumably).
@howardjohn howardjohn mentioned this issue May 9, 2022
Merged
howardjohn added a commit to howardjohn/gateway-api that referenced this issue May 12, 2022
@howardjohn
conformance: allow error status in Route
7d6288a 
Fixes kubernetes-sigs#1135

This changes tests to assert their is either no parent at all, or a
non-accepted parent (indicating an error message, presumably).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/conformance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

conformance: allow error status in Route howardjohn/gateway-api
1 participant
@robscott