conformance: allow error status in Route #1152
Conversation
k8s-ci-robot
added
kind/bug
|
Hi @howardjohn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -177,6 +177,41 @@ func WaitForGatewayAddress(t *testing.T, client client.Client, gwName types.Name | |||
| return net.JoinHostPort(ipAddr, port), waitErr | |||
| } | |||
|
|
|||
| // HTTPRouteMustHaveParents waits for the specified HTTPRoute to have either no parents | |||
There was a problem hiding this comment.
| // HTTPRouteMustHaveParents waits for the specified HTTPRoute to have either no parents | |
| // HTTPRouteMustHaveNoAcceptedParents waits for the specified HTTPRoute to have either no parents |
|
|
||
| var actual []v1alpha2.RouteParentStatus | ||
| waitFor := time.Duration(seconds) * time.Second | ||
| waitErr := wait.PollImmediate(1*time.Second, waitFor, func() (bool, error) { |
There was a problem hiding this comment.
I'm not really sure what the solution is here, but this seems like something that could accidentally pass if a controller just hadn't gotten around to populating status yet. I hate to add delay for the sake of delay, but maybe we need to wait a few seconds before accepting len(actual) == 0 as a successful result. If status is populated that seems sufficient to pass immediately, but not quite sure about the lack of conditions resulting in an immediate pass.
There was a problem hiding this comment.
added a delay only in this case
Fixes kubernetes-sigs#1135 This changes tests to assert their is either no parent at all, or a non-accepted parent (indicating an error message, presumably).
howardjohn
force-pushed
the
conformance/route-error
branch
from
1aeacae to
9e21fa4
Compare
|
Thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Fixes #1135
This changes tests to assert their is either no parent at all, or a
non-accepted parent (indicating an error message, presumably).
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: