generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define whether path prefix matches are element-wise or byte-wise #866
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
Comments
jpeach
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Sep 14, 2021
I am a +1 for making these definitions line up. It makes the migration easier for users, and for Contour, we've already implemented these, so we can easily reuse code. |
+1 to sticking to element-wise. Any use-cases we know of that won't be satisfied with that approach? |
jpeach
added a commit
to jpeach/gateway-api
that referenced
this issue
Sep 15, 2021
Explicitly align path prefix matching with the Ingress API by specifying it as an prefix of path elements, not a prefix of bytes. This fixes kubernetes-sigs#866. Signed-off-by: James Peach <jpeach@apache.org>
jpeach
added a commit
to jpeach/gateway-api
that referenced
this issue
Sep 21, 2021
Explicitly align path prefix matching with the Ingress API by specifying it as an prefix of path elements, not a prefix of bytes. This fixes kubernetes-sigs#866. Signed-off-by: James Peach <jpeach@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Gateway defines a prefix match like this:
But Ingress V1 says:
I don't recall a discussion about this, but we should discuss whether to align the Gateway prefix semantics with Ingress.
The text was updated successfully, but these errors were encountered: