Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: prefix matching should match a whole path segment #4092

Closed
skriss opened this issue Oct 8, 2021 · 1 comment · Fixed by #4119
Closed

Gateway API: prefix matching should match a whole path segment #4092

skriss opened this issue Oct 8, 2021 · 1 comment · Fixed by #4119
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.20.0

Comments

@skriss
Copy link
Member

skriss commented Oct 8, 2021 •
edited
Loading

ref. https://gateway-api.sigs.k8s.io/v1alpha2/references/spec/#gateway.networking.k8s.io/v1alpha2.PathMatchType
ref. kubernetes-sigs/gateway-api#866
ref. kubernetes-sigs/gateway-api#869

For v1alpha2, prefix path matching has to match an entire path segment, not just be a string prefix. This is like the Segment prefix match type for Ingress.
@skriss skriss added kind/feature Categorizes issue or PR as related to a new feature. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Oct 8, 2021
@skriss skriss self-assigned this Oct 11, 2021
@skriss skriss added this to the 1.20.0 milestone Oct 11, 2021
@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Oct 11, 2021
@skriss
Copy link
Member Author

skriss commented Oct 13, 2021

I've got this implemented, just waiting for v1alpha2 support to merge.

skriss added a commit to skriss/contour that referenced this issue Oct 13, 2021
@skriss
internal/dag: use segment prefix matching for Gateway API
dd079be 
Switches from string prefix path matching to
segment prefix patch matching for Gateway API
to correctly implement the v1alpha2 spec. In
short, a prefix of '/foo' will now match
'/foo/bar' but not '/foobar'.

Closes projectcontour#4092.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Oct 15, 2021
@skriss
internal/dag: use segment prefix matching for Gateway API
3053ae1 
Switches from string prefix path matching to
segment prefix patch matching for Gateway API
to correctly implement the v1alpha2 spec. In
short, a prefix of '/foo' will now match
'/foo/bar' but not '/foobar'.

Closes projectcontour#4092.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Oct 15, 2021
Merged
stevesloka pushed a commit that referenced this issue Oct 19, 2021
@skriss
internal/dag: use path prefix matching for Gateway API (#4119)
6321458 
Switches from string prefix path matching to
segment prefix patch matching for Gateway API
to correctly implement the v1alpha2 spec. In
short, a prefix of '/foo' will now match
'/foo/bar' but not '/foobar'.

Closes #4092.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

internal/dag: use path prefix matching for Gateway API skriss/contour
1 participant
@skriss