Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating obsolete gateway-api namespace #1063

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Avoid creating obsolete gateway-api namespace #1063

merged 1 commit into from
Mar 23, 2022

Conversation

markmc
Copy link
Contributor

@markmc markmc commented Mar 23, 2022

Small issue in #1051 - both manifests create the required namespace and we only renamed gateway-api to gateway-system in one of them.

Before:

namespace/gateway-system created
validatingwebhookconfiguration.admissionregistration.k8s.io/gateway-api-admission created
service/gateway-api-admission-server created
deployment.apps/gateway-api-admission-server created
namespace/gateway-api created

after:

namespace/gateway-system created
validatingwebhookconfiguration.admissionregistration.k8s.io/gateway-api-admission created
service/gateway-api-admission-server created
deployment.apps/gateway-api-admission-server created
namespace/gateway-system unchanged

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @markmc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markmc markmc changed the title Avoid creating obselete gateway-api namespace Avoid creating obsolete gateway-api namespace Mar 23, 2022
@k8s-ci-robot k8s-ci-robot requested review from jpeach and robscott March 23, 2022 17:58
@markmc
Avoid creating obsolete gateway-api namespace
f9790fc 
Small issue in commit 08eae8a - both manifests create the required
namespace and we only renamed gateway-api to gateway-system in one of
them.

Before:

  namespace/gateway-system created
  validatingwebhookconfiguration.admissionregistration.k8s.io/gateway-api-admission created
  service/gateway-api-admission-server created
  deployment.apps/gateway-api-admission-server created
  namespace/gateway-api created

after:

  namespace/gateway-system created
  validatingwebhookconfiguration.admissionregistration.k8s.io/gateway-api-admission created
  service/gateway-api-admission-server created
  deployment.apps/gateway-api-admission-server created
  namespace/gateway-system unchanged
@markmc markmc force-pushed the namespace-rename branch from 436acf9 to f9790fc Compare March 23, 2022 18:00
@robscott
Copy link
Member

Thanks @markmc!

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmc, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2022
@robscott
Copy link
Member

robscott commented Mar 23, 2022 •
edited
Loading

Looks like a flake in kind setup?

hack/../hack/verify-examples-kind.sh: line 52: kind: command not found

/retest

@robscott robscott mentioned this pull request Mar 23, 2022
Merged
@robscott
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit f63f7da into kubernetes-sigs:master Mar 23, 2022
@markmc markmc deleted the namespace-rename branch March 24, 2022 17:20
@markmc markmc mentioned this pull request Apr 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach Awaiting requested review from jpeach

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markmc @k8s-ci-robot @robscott