Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for CPUCFSQuota #187

Merged
merged 5 commits into from
Jan 31, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/apis/crds/karpenter.sh_machines.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ spec:
description: ContainerRuntime is the container runtime to be used
with your worker nodes.
type: string
cpuCFSQuota:
description: CPUCFSQuota enables CPU CFS quota enforcement for
containers that specify CPU limits.
type: boolean
evictionHard:
additionalProperties:
type: string
Expand Down
4 changes: 4 additions & 0 deletions pkg/apis/crds/karpenter.sh_provisioners.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ spec:
description: ContainerRuntime is the container runtime to be used
with your worker nodes.
type: string
cpuCFSQuota:
description: CPUCFSQuota enables CPU CFS quota enforcement for
containers that specify CPU limits.
type: boolean
evictionHard:
additionalProperties:
type: string
Expand Down
3 changes: 3 additions & 0 deletions pkg/apis/v1alpha5/machine.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ type KubeletConfiguration struct {
// +kubebuilder:validation:Maximum:=100
// +optional
ImageGCLowThresholdPercent *int32 `json:"imageGCLowThresholdPercent,omitempty"`
// CPUCFSQuota enables CPU CFS quota enforcement for containers that specify CPU limits.
// +optional
CPUCFSQuota bool `json:"cpuCFSQuota,omitempty"`
}

type ProviderRef struct {
Expand Down
8 changes: 8 additions & 0 deletions pkg/apis/v1alpha5/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -480,5 +480,13 @@ var _ = Describe("Validation", func() {
Expect(provisioner.Validate(ctx)).ToNot(Succeed())
})
})
Context("CPUCFSQuota", func() {
lucass4 marked this conversation as resolved.
Show resolved Hide resolved
It("should succeed on CPUCFSQuota with valid value", func() {
provisioner.Spec.KubeletConfiguration = &KubeletConfiguration{
CPUCFSQuota: *ptr.Bool(true),
}
Expect(provisioner.Validate(ctx)).To(Succeed())
})
})
})
})