perf: improve scheduling with large numbers of nodes using hostname topologies #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particularly helps with pod anti-affinities. I modified the benchmark to have 500 self anti-affinity pods and this improves the performance by 1000% at 500 pods/nodes. The more nodes, the better the improvement. name old pods/sec new pods/sec delta Scheduling500-12 15.3 ±10% 171.3 ± 7% +1022.36% (p=0.008 n=5+5)
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Pull Request Test Coverage Report for Build 7646346732
💛 - Coveralls |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, tzneal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bryce-Soghigian
pushed a commit
to Bryce-Soghigian/karpenter-core
that referenced
this pull request
Jan 25, 2024
engedaam
pushed a commit
to engedaam/karpenter-core
that referenced
this pull request
Jan 25, 2024
This was referenced Jan 25, 2024
engedaam
pushed a commit
to engedaam/karpenter-core
that referenced
this pull request
Jan 29, 2024
jigisha620
pushed a commit
to jigisha620/karpenter
that referenced
this pull request
Jan 29, 2024
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This particularly helps with pod anti-affinities. I modified the benchmark to have 500 self anti-affinity pods and this improves the performance by 1000% at 500 pods/nodes. The more nodes, the better the improvement.
name old pods/sec new pods/sec delta
Scheduling500-12 15.3 ±10% 171.3 ± 7% +1022.36% (p=0.008 n=5+5)
How was this change tested?
Benchmarking
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.