Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adding cherry picked commits to release-v0.32.x #965

Merged
merged 3 commits into from
Jan 25, 2024
Merged

chore: Adding cherry picked commits to release-v0.32.x #965

merged 3 commits into from
Jan 25, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jan 25, 2024 •
edited
Loading

Fixes #N/A

Description

How was this change tested?

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2024
@engedaam engedaam changed the title chore: Adding cherry picked commits to release-v0.32.x chore: Adding cherry picked commits to release-v0.32.x Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2024
jonathan-innis
jonathan-innis approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
jonathan-innis
jonathan-innis approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@engedaam
Copy link
Contributor Author

/approve

njtran
njtran reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: engedaam, jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njtran njtran merged commit e0cf0f2 into kubernetes-sigs:release-v0.32.x Jan 25, 2024
7 of 8 checks passed
@engedaam engedaam deleted the v0.32.6-cherrypick branch January 25, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran left review comments

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees

@njtran njtran

@jonathan-innis jonathan-innis

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@engedaam @k8s-ci-robot @njtran @jonathan-innis @tzneal