Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Supported Pod Affinity/Anti-Affinity Predicate. #418

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Supported Pod Affinity/Anti-Affinity Predicate. #418

merged 1 commit into from
Oct 14, 2018

Conversation

k82cn
Copy link
Contributor

@k82cn k82cn commented Oct 11, 2018

Signed-off-by: Da K. Ma klaus1982.cn@gmail.com

fixes: #337

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2018
@k8s-ci-robot k8s-ci-robot requested a review from jinzhejz October 11, 2018 13:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2018
@k82cn k82cn changed the title Supported Pod Affinity/Anti-Affinity Predicate. WIP: Supported Pod Affinity/Anti-Affinity Predicate. Oct 11, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2018
@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make
$ make
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
pkg/scheduler/plugins/predicates/predicates.go:22:2: cannot find package "github.com/kubernetes-incubator/kube-arbitrator/pkg/scheduler/framework" in any of:
	/home/travis/gopath/src/github.com/kubernetes-sigs/kube-batch/vendor/github.com/kubernetes-incubator/kube-arbitrator/pkg/scheduler/framework (vendor tree)
	/home/travis/.gimme/versions/go1.10.linux.amd64/src/github.com/kubernetes-incubator/kube-arbitrator/pkg/scheduler/framework (from $GOROOT)
	/home/travis/gopath/src/github.com/kubernetes-incubator/kube-arbitrator/pkg/scheduler/framework (from $GOPATH)
make: *** [kube-batch] Error 1
make e2e
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
pkg/scheduler/plugins/predicates/predicates.go:22:2: cannot find package "github.com/kubernetes-incubator/kube-arbitrator/pkg/scheduler/framework" in any of:
	/home/travis/gopath/src/github.com/kubernetes-sigs/kube-batch/vendor/github.com/kubernetes-incubator/kube-arbitrator/pkg/scheduler/framework (vendor tree)
	/home/travis/.gimme/versions/go1.10.linux.amd64/src/github.com/kubernetes-incubator/kube-arbitrator/pkg/scheduler/framework (from $GOROOT)
	/home/travis/gopath/src/github.com/kubernetes-incubator/kube-arbitrator/pkg/scheduler/framework (from $GOPATH)
make: *** [kube-batch] Error 1
TravisBuddy Request Identifier: 0a502c90-cd59-11e8-9005-69b5ac3c7904

@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make
$ make
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
# github.com/kubernetes-sigs/kube-batch/pkg/scheduler/plugins/predicates
pkg/scheduler/plugins/predicates/predicates.go:48:11: undefined: podList
pkg/scheduler/plugins/predicates/predicates.go:48:43: undefined: schedulercache
pkg/scheduler/plugins/predicates/predicates.go:48:78: undefined: labels
pkg/scheduler/plugins/predicates/predicates.go:48:99: undefined: v1
make: *** [kube-batch] Error 2
make e2e
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
# github.com/kubernetes-sigs/kube-batch/pkg/scheduler/plugins/predicates
pkg/scheduler/plugins/predicates/predicates.go:48:11: undefined: podList
pkg/scheduler/plugins/predicates/predicates.go:48:43: undefined: schedulercache
pkg/scheduler/plugins/predicates/predicates.go:48:78: undefined: labels
pkg/scheduler/plugins/predicates/predicates.go:48:99: undefined: v1
make: *** [kube-batch] Error 2
TravisBuddy Request Identifier: 429785d0-cd59-11e8-9005-69b5ac3c7904

@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make
$ make
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
# github.com/kubernetes-sigs/kube-batch/pkg/scheduler/plugins/predicates
pkg/scheduler/plugins/predicates/predicates.go:60:11: undefined: podList
pkg/scheduler/plugins/predicates/predicates.go:60:43: undefined: schedulercache
make: *** [kube-batch] Error 2
make e2e
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
# github.com/kubernetes-sigs/kube-batch/pkg/scheduler/plugins/predicates
pkg/scheduler/plugins/predicates/predicates.go:60:11: undefined: podList
pkg/scheduler/plugins/predicates/predicates.go:60:43: undefined: schedulercache
make: *** [kube-batch] Error 2
TravisBuddy Request Identifier: cad64c40-cd5b-11e8-9005-69b5ac3c7904

@k82cn k82cn changed the title WIP: Supported Pod Affinity/Anti-Affinity Predicate. Supported Pod Affinity/Anti-Affinity Predicate. Oct 12, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2018
@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d8456660-cdbd-11e8-9005-69b5ac3c7904

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 752644d0-cdbf-11e8-9005-69b5ac3c7904

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 585d13f0-cdc0-11e8-9005-69b5ac3c7904

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 09154380-cdc5-11e8-9005-69b5ac3c7904

@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make
$ make
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
# github.com/kubernetes-sigs/kube-batch/pkg/scheduler/plugins/predicates
pkg/scheduler/plugins/predicates/predicates.go:55:39: task.Pod undefined (type api.tasksMap has no field or method Pod)
pkg/scheduler/plugins/predicates/predicates.go:56:29: task.Pod undefined (type api.tasksMap has no field or method Pod)
pkg/scheduler/plugins/predicates/predicates.go:68:27: cannot use status (type api.TaskID) as type api.TaskStatus in argument to api.AllocatedStatus
make: *** [kube-batch] Error 2
make e2e
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
# github.com/kubernetes-sigs/kube-batch/pkg/scheduler/plugins/predicates
pkg/scheduler/plugins/predicates/predicates.go:55:39: task.Pod undefined (type api.tasksMap has no field or method Pod)
pkg/scheduler/plugins/predicates/predicates.go:56:29: task.Pod undefined (type api.tasksMap has no field or method Pod)
pkg/scheduler/plugins/predicates/predicates.go:68:27: cannot use status (type api.TaskID) as type api.TaskStatus in argument to api.AllocatedStatus
make: *** [kube-batch] Error 2
TravisBuddy Request Identifier: 05ee57a0-cdde-11e8-9005-69b5ac3c7904

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2018
@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 61c8bf50-ce03-11e8-b4b8-efdbea9fb873

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1eaa2300-cf50-11e8-8f06-df00502df958

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: fb302bf0-cf58-11e8-8f06-df00502df958

Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
@k82cn
Copy link
Contributor Author

k82cn commented Oct 14, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@k82cn: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit a8c4ea2 into kubernetes-retired:master Oct 14, 2018
@k82cn k82cn deleted the kb_337 branch October 14, 2018 02:54
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Supported Pod Affinity/Anti-Affinity Predicate.
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Supported Pod Affinity/Anti-Affinity Predicate.
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Supported Pod Affinity/Anti-Affinity Predicate.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does kube-arbitrator support pod affinity?
3 participants