Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Use log from context #2181

Merged
merged 1 commit into from
May 18, 2021
Merged

✨ Use log from context #2181

merged 1 commit into from
May 18, 2021

Conversation

mrkm4ntr
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @mrkm4ntr!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mrkm4ntr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2021
@k8s-ci-robot k8s-ci-robot requested review from mengqiy and pwittrock May 12, 2021 13:28
@estroz
Copy link
Contributor

estroz commented May 18, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2021
@estroz
Copy link
Contributor

estroz commented May 18, 2021

Seems reasonable, thanks @mrkm4ntr!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, mrkm4ntr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit e9e789d into kubernetes-sigs:master May 18, 2021
@armsnyder armsnyder mentioned this pull request Aug 10, 2021
Closed
petersutter added a commit to gardener/terminal-controller-manager that referenced this pull request Nov 24, 2021
@petersutter
Use log from context kubernetes-sigs/kubebuilder#2181
a267539
petersutter added a commit to gardener/terminal-controller-manager that referenced this pull request Apr 4, 2022
@petersutter @grolu
Update kubebuilder scaffolding and dependencies, use CRD v1 (#59)
1708f2f 
* update to latest kubebuilder scaffolding

bump dependencies

fix tests by creating valid service account token

bump golang to 1.17.3

fix issue with zap-devel flag

* bump controller-runtime to v0.10.2

* Use log from context kubernetes-sigs/kubebuilder#2181

* Tag boilerplate Makefile targets as .PHONY

* Add default-container annotation

* Add flag for ignore-not-found to make undeploy

* fix(scaffolds): better defaults

* Defer GinkgoRecover() in test goroutines

* ignore non-go files during Docker build

* bump golang to 1.17.5

* Apply suggestions from code review

Co-authored-by: Lukas Gross <35373687+grolu@users.noreply.github.com>

Co-authored-by: Lukas Gross <35373687+grolu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy Awaiting requested review from mengqiy

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrkm4ntr @k8s-ci-robot @estroz