✨ fix(scaffolds): better defaults

[longkai]

• explicitly specify port protocol where missing
• larger resource limit for controller manager

With the original default manifest, the server-side-apply would fail since the required protocol field is missing.

This is actually a k8s bug and should not be omitted before 1.20.

The default controller manager resource limit is too low for downloading small amount (~30kb) of http resource. It results a OOMKilled Pod status and no logs could be found.

Sometimes you got the CrashLoopBackOff status but no logs found, which took me sometime to figure it out.

We can watch the status transition via kubectl get po -w:

bootstrap-controller-manager-8f88c7b5b-gplpg   2/2     Running            4          3m59s
bootstrap-controller-manager-8f88c7b5b-gplpg   1/2     OOMKilled          4          4m5s
bootstrap-controller-manager-8f88c7b5b-gplpg   1/2     CrashLoopBackOff   4          4m10s
bootstrap-controller-manager-8f88c7b5b-gplpg   1/2     Running            5          5m27s
bootstrap-controller-manager-8f88c7b5b-gplpg   2/2     Running            5          5m39s
bootstrap-controller-manager-8f88c7b5b-gplpg   1/2     OOMKilled          5          6m4s
bootstrap-controller-manager-8f88c7b5b-gplpg   1/2     CrashLoopBackOff   5          6m9s

I suppose this default improves the user experience especially for beginners.

[k8s-ci-robot]

Welcome @longkai!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @longkai. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[estroz]

/ok-to-test

[estroz]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, longkai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment