Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unknown 'kubernetes.io' or 'k8s.io' labels specified with --node-labels #4320

Merged
merged 6 commits into from
Apr 10, 2019

Conversation

r0b2g1t
Copy link
Contributor

@r0b2g1t r0b2g1t commented Mar 5, 2019

During the initialization of the cluster Kubelet assigns the assignment of the node with the parameter --node-labels (node-role.kubernetes.io/master= or node-role.kubernetes.io/node=). The namespace prefix node-role is not available.

Feb 12 16:39:19 k8s-test-cluster-k8s-master-nf-1 kubelet: W0212 16:39:19.932837   23343 options.go:265] unknown 'kubernetes.io' or 'k8s.io' labels specified with --node-labels: [node-role.kubernetes.io/master]
Feb 12 16:39:19 k8s-test-cluster-k8s-master-nf-1 kubelet: W0212 16:39:19.932847   23343 options.go:266] in 1.15, --node-labels in the 'kubernetes.io' namespace must begin with an allowed prefix (kubelet.kubernetes.io, node.kubernetes.io) or be in the specifically allowed set (beta.kubernetes.io/arch, beta.kubernetes.io/instance-type, beta.kubernetes.io/os, failure-domain.beta.kubernetes.io/region, failure-domain.beta.kubernetes.io/zone, failure-domain.kubernetes.io/region, failure-domain.kubernetes.io/zone, kubernetes.io/arch, kubernetes.io/hostname, kubernetes.io/instance-type, kubernetes.io/os)

@Miouge1: I have to recreate the PR (#4220) for move the changes to a separate branch.

@k8s-ci-robot k8s-ci-robot requested review from Miouge1 and mirwan March 5, 2019 16:24
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2019
@Miouge1
Copy link
Contributor

Miouge1 commented Mar 6, 2019

ci check this

@woopstar woopstar added this to the 2.10 milestone Apr 9, 2019
@woopstar
Copy link
Member

woopstar commented Apr 9, 2019

Needs a rebase

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2019
@r0b2g1t
Copy link
Contributor Author

r0b2g1t commented Apr 10, 2019

Needs a rebase

Rebase is done :-)

@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r0b2g1t, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 586ad89 into kubernetes-sigs:master Apr 10, 2019
woopstar added a commit that referenced this pull request Apr 17, 2019
Miouge1 added a commit to Miouge1/kubespray that referenced this pull request Apr 17, 2019
k8s-ci-robot pushed a commit that referenced this pull request Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants