Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix for unknown 'kubernetes.io' or 'k8s.io' labels specified with --node-labels" #4551

Closed
wants to merge 1 commit into from

Conversation

woopstar
Copy link
Member

@woopstar woopstar commented Apr 17, 2019

Reverts #4320

Apparently kubernetes still uses the node-role label:

https://github.com/kubernetes/kubernetes/blob/release-1.14/pkg/controller/service/service_controller.go#L66

See more at this link:

kubernetes/kubernetes#68267 (comment)

This also had the side-effect that CoreDNS, Nodelocaldns and others did not start on a single instance with taints

@k8s-ci-robot k8s-ci-robot requested a review from Miouge1 April 17, 2019 13:38
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from mirwan April 17, 2019 13:38
@woopstar
Copy link
Member Author

ci check this

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2019
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 17, 2019

I can confirm this issue. We need CI to catch this kind of problems: #4552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants