Enable nodelocaldns by default #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woopstar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
ci check this |
k8s-ci-robot
added
the
size/XS
|
Two questions:
|
After 2.9.0 rls. :) I removed it, but maybe we should consider to set it to false in some test? |
|
Good point with adding it to another test. I'll set it this on hold until 2.9.0 release then. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Disable enable_nodelocaldns for the addons CI jobs to make sure things still work without nodelocaldns
|
#4492 must be merged too |
|
#4492 is merged so we can go-ahead /lgtm |
k8s-ci-robot
added
the
lgtm
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
May 5, 2019
* Enable nodelocaldns by default * Enable nodelocaldns by default * nodelocaldns is now default * Disable enable_nodelocaldns for the addons CI jobs Disable enable_nodelocaldns for the addons CI jobs to make sure things still work without nodelocaldns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable nodelocaldns by default as Kubespray is "production-ready".
Nodelocaldns prevents / mitigates racy DNS connections.
See more at: