Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for packet_centos7-flannel-addons #4586

Merged

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Apr 19, 2019

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
packet_centos7-flannel-addons was broken since the merge of the new Packet CI. This is a fix for that and moves the centos7-flannel-addons from GCE to Packet CI.

Also note that the packet version of packet_centos7-flannel-addons did not include changes from #4514 and #4461 so this PR also updates that.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2019
@k8s-ci-robot k8s-ci-robot requested a review from Atoms April 19, 2019 21:36
@Miouge1
Copy link
Contributor Author

Miouge1 commented Apr 19, 2019

ci check this

@k8s-ci-robot k8s-ci-robot requested a review from mirwan April 19, 2019 21:36
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2019
@Miouge1
Copy link
Contributor Author

Miouge1 commented Apr 19, 2019

/assign @woopstar

@Miouge1 Miouge1 added this to the 2.10 milestone Apr 19, 2019
@Miouge1 Miouge1 changed the title [WIP] Fix CI for packet_centos7-flannel-addons Fix CI for packet_centos7-flannel-addons Apr 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2019
@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4de6a78 into kubernetes-sigs:master Apr 20, 2019
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants