-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify dnsConfig in helm chart #1344
Conversation
Welcome @audip! |
Hi @audip. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @stevehipwell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @audip. I've added a comment to the change and could you also add the new chart input to the README.
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
/triage accepted |
/label tide/merge-method-squash |
/retest |
1 similar comment
/retest |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: audip, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update values.yaml * Update deployment.yaml * Update charts/metrics-server/templates/deployment.yaml Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com> * Update helm chart README to add dnsConfig * Fix curly braces as default input for dnsConfig --------- Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
What this PR does / why we need it:
Changes:
This allows specifying dnsConfig block like mentioned in the kubernetes documentation
One example of what's in use at @myfitnesspal is
screenshot of how the dns configuration is rendered on the deployment resource