Skip to content

Commit

Permalink
Add ability to specify dnsConfig in helm chart (kubernetes-sigs#1344)
Browse files Browse the repository at this point in the history
* Update values.yaml

* Update deployment.yaml

* Update charts/metrics-server/templates/deployment.yaml

Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>

* Update helm chart README to add dnsConfig

* Fix curly braces as default input for dnsConfig

---------

Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
  • Loading branch information
2 people authored and zhuxiaow0 committed Nov 11, 2023
1 parent 68624e9 commit 474330f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/metrics-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,4 @@ The following table lists the configurable parameters of the _Metrics Server_ ch
| `topologySpreadConstraints` | Pod Topology Spread Constraints. | `[]` |
| `deploymentAnnotations` | Annotations to add to the deployment. | `{}` |
| `schedulerName` | scheduler to set to the deployment. | `""` |
| `dnsConfig` | Set the dns configuration options for the deployment. | `{}` |
4 changes: 4 additions & 0 deletions charts/metrics-server/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ spec:
{{- if .Values.hostNetwork.enabled }}
hostNetwork: true
{{- end }}
{{- with .Values.dnsConfig }}
dnsConfig:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:
- name: metrics-server
{{- with .Values.securityContext }}
Expand Down
2 changes: 2 additions & 0 deletions charts/metrics-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ affinity: {}

topologySpreadConstraints: []

dnsConfig: {}

# Annotations to add to the deployment
deploymentAnnotations: {}

Expand Down

0 comments on commit 474330f

Please sign in to comment.