-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backporting support for Regional Instance Template GCE to 1.29 #7231
base: cluster-autoscaler-release-1.29
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Edwinhr716 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
machinesCache: map[MachineTypeKey]MachineType{}, | ||
migTargetSizeCache: map[GceRef]int64{}, | ||
migBaseNameCache: map[GceRef]string{}, | ||
listManagedInstancesResultsCache: map[GceRef]string{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add listManagedInstancesResultsCache
? You don't seem to be using it anywhere and it wasn't a part of your original PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snuck through when merging the PR to the branch, removed it from the PR.
Cherry pick of #6570 on cluster-autoscaler-release-1.29.
#6570: made changes to support MIGs that use regional instance
For details on the cherry pick process, see the cherry pick requests page.