Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional instance #6570

Merged
merged 12 commits into from
Mar 14, 2024
Merged

Conversation

Edwinhr716
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Need to support Regional Instance Templates. TWithout this change, whenever FetchMIGTemplate gets called, it will fail to find the instance template that is attached to the MIG, as it will call the global GCE API instead of regional one.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 27, 2024
Copy link

linux-foundation-easycla bot commented Feb 27, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added area/provider/gce cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 27, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Edwinhr716!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 27, 2024
Copy link
Contributor

@BigDarkClown BigDarkClown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review done. Please rebase on master and fix the issues, then ping me to take another look.

@Edwinhr716 Edwinhr716 force-pushed the regional-instance branch 2 times, most recently from 2f71dd9 to 9333210 Compare March 13, 2024 21:34
@k8s-ci-robot k8s-ci-robot added area/provider/externalgrpc Issues or PRs related to the External gRPC provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 13, 2024
@Edwinhr716 Edwinhr716 force-pushed the regional-instance branch 3 times, most recently from 3b8ae5f to 751ef66 Compare March 13, 2024 22:25
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 13, 2024
@BigDarkClown
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BigDarkClown, Edwinhr716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit ffe9680 into kubernetes:master Mar 14, 2024
6 checks passed
@x13n
Copy link
Member

x13n commented Aug 30, 2024

/cherry-pick cluster-autoscaler-release-1.29

@k8s-infra-cherrypick-robot

@x13n: #6570 failed to apply on top of branch "cluster-autoscaler-release-1.29":

Applying: made changes to support MIGs that use regional instance templates
Using index info to reconstruct a base tree...
M	cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go
M	cluster-autoscaler/cloudprovider/gce/cache.go
M	cluster-autoscaler/cloudprovider/gce/mig_info_provider.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/cloudprovider/gce/mig_info_provider.go
Auto-merging cluster-autoscaler/cloudprovider/gce/cache.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/gce/cache.go
Auto-merging cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go
CONFLICT (content): Merge conflict in cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 made changes to support MIGs that use regional instance templates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick cluster-autoscaler-release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/externalgrpc Issues or PRs related to the External gRPC provider area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants