Update registry k8s.gcr.io -> registry.k8s.io #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
ArkaSaha30
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/retest-required |
|
@ArkaSaha30 can you rebase your branch against master, it has fixes to CI tests |
ArkaSaha30
force-pushed
the
migrate-registry
branch
2 times, most recently
from
23ecfcb
to
a6faa94
Compare
|
/retest |
|
@zetaab the tests are still failing, is it falky? Or should I create a fresh PR and check? |
|
its reported to sig-testing, there are some problems with the serviceaccount tokens |
|
/retest |
|
/lgtm looks like there are some changes that already done #2100 |
k8s-ci-robot
added
the
lgtm
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
ArkaSaha30
force-pushed
the
migrate-registry
branch
from
a6faa94
to
a1d40c8
Compare
k8s-ci-robot
removed
the
lgtm
ArkaSaha30
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks @jichenjc for the quick response, if its all good can you please approve this PR as well? |
|
/approve :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closed
85 tasks
m-bull
pushed a commit
to stackhpc/cloud-provider-openstack
that referenced
this pull request
Feb 23, 2023
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com> Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
m-bull
pushed a commit
to stackhpc/cloud-provider-openstack
that referenced
this pull request
Feb 23, 2023
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com> Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will update the uses of deprecating
[k8s.gcr.io](http://k8s.gcr.io/)registry to[registry.k8s.io](http://registry.k8s.io/)prior to the planned April freeze.Which issue this PR fixes(if applicable):
fixes # kubernetes/k8s.io#4738
Special notes for reviewers:
Search results: https://cs.k8s.io/?q=k8s.gcr.io&i=nope&files=&excludeFiles=vendor%2F&repos=kubernetes/cloud-provider-openstack
Release note: