-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Services are up to 24 chars long. Make app name at least that long. #411
Comments
The claim in the corresponding test is not correct! Also, the pattern is not be correct! Can you please verify that everything is correct? |
I can fix this (sorry I didn't spot earlier), but the implication is that now, with our current setup (input from 'App name' is used for generating service name, label name, and RC name), the longest an app name can be is 24 chars, with the further restriction that the first character can no longer be a number. As I say, happy to fix for now, but that is one big restriction... |
@cheld suggested that we keep the current implementation. I will have a fix shortly restricting app name field to 24 chars and only lowercase letter as first char in line with the service pattern. |
Awesome |
This is what happened when I wanted to create a service with more that 24 chars:
The text was updated successfully, but these errors were encountered: