Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services are up to 24 chars long. Make app name at least that long. #411

Closed
bryk opened this issue Feb 22, 2016 · 5 comments
Closed

Services are up to 24 chars long. Make app name at least that long. #411

bryk opened this issue Feb 22, 2016 · 5 comments

Comments

@bryk
Copy link
Contributor

bryk commented Feb 22, 2016

This is what happened when I wanted to create a service with more that 24 chars:

 Details: must be a DNS 952 label (at most 24 characters, matching regex [a-z]([-a-z0-9]*[a-z0-9])?): e.g. "my-name"
@cheld
Copy link
Contributor

cheld commented Feb 23, 2016

@bryk bryk added this to the v1.0 milestone Feb 23, 2016
@digitalfishpond
Copy link
Contributor

I can fix this (sorry I didn't spot earlier), but the implication is that now, with our current setup (input from 'App name' is used for generating service name, label name, and RC name), the longest an app name can be is 24 chars, with the further restriction that the first character can no longer be a number. As I say, happy to fix for now, but that is one big restriction...

@digitalfishpond
Copy link
Contributor

@cheld suggested that we keep the current implementation. I will have a fix shortly restricting app name field to 24 chars and only lowercase letter as first char in line with the service pattern.

@bryk
Copy link
Contributor Author

bryk commented Feb 23, 2016

Awesome

@cheld
Copy link
Contributor

cheld commented Feb 25, 2016

Layout is destroyed for 63 chars on firefox. 24 works
long-name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants