App name validation fix #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
|
||
| /** | ||
| * Maximum length for Application name | ||
| * @export {string} | ||
| */ | ||
| this.nameMaxLength = '63'; | ||
| this.nameMaxLength = '24'; |
There was a problem hiding this comment.
test must be adapted as well
There was a problem hiding this comment.
@cheld PTAL
digitalfishpond
force-pushed
the
service-name-maxchars
branch
2 times, most recently
from
127ad06 to
f1510f5
Compare
…ts first char to lowercase letter
digitalfishpond
force-pushed
the
service-name-maxchars
branch
from
f1510f5 to
9560ea0
Compare
|
LGTM |
|
Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#411
App name is restricted to 24 chars and regex pattern now also restricts first char to lowercase letter