Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS compiler fixes after new compiler release #581

Merged
merged 1 commit into from
Mar 29, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Mar 29, 2016

This change is Reviewable

@bryk
Copy link
Contributor Author

bryk commented Mar 29, 2016

@floreks Can you take a look?

@codecov-io
Copy link

Current coverage is 86.89%

Merging #581 into master will increase coverage by +0.35% as of 185a7d0

@@            master    #581   diff @@
======================================
  Files           97     102     +5
  Stmts          847     870    +23
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            733     756    +23
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 185a7d0

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 29, 2016

:lgtm:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@bryk bryk merged commit 40ffe25 into kubernetes:master Mar 29, 2016
@bryk bryk deleted the compiler-fix branch March 29, 2016 07:35
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants