-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signin button): signin button is clickable when token is autofilled by browser #9610
fix(signin button): signin button is clickable when token is autofilled by browser #9610
Conversation
/lgtm |
@maciaszczykm wasn't there some kind of issue when using |
It all works ok with Paste with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for the fix.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, lsq645599166, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9610 +/- ##
=======================================
Coverage 35.88% 35.88%
=======================================
Files 301 301
Lines 14501 14501
Branches 183 183
=======================================
Hits 5204 5204
Misses 9073 9073
Partials 224 224 |
close #8755
Keep sign in button clickable when token is autofilled by browser
Screenshot
Firefox
20241029-174125.mp4
Chrome
When Chrome, must have an interaction with the browser.
20241029-174505.mp4