Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signin button): signin button is clickable when token is autofilled by browser #9610

Merged

Conversation

lsq645599166
Copy link
Contributor

close #8755

Keep sign in button clickable when token is autofilled by browser

Screenshot

Firefox

20241029-174125.mp4

Chrome

When Chrome, must have an interaction with the browser.

20241029-174505.mp4

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2024
@maciaszczykm maciaszczykm added the kind/bug Categorizes issue or PR as related to a bug. label Oct 29, 2024
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2024
@floreks
Copy link
Member

floreks commented Oct 30, 2024

@maciaszczykm wasn't there some kind of issue when using input event type too? What about copy-paste action?

@lsq645599166
Copy link
Contributor Author

@maciaszczykm wasn't there some kind of issue when using input event type too? What about copy-paste action?

It all works ok with input event

Paste with CMD + v

20241031-115406.mp4

Paste with mouse

20241031-115505.mp4

Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for the fix.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, lsq645599166, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e49059 into kubernetes:master Oct 31, 2024
16 checks passed
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.88%. Comparing base (8c15a76) to head (4e3004b).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9610   +/-   ##
=======================================
  Coverage   35.88%   35.88%           
=======================================
  Files         301      301           
  Lines       14501    14501           
  Branches      183      183           
=======================================
  Hits         5204     5204           
  Misses       9073     9073           
  Partials      224      224           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactivity bug in web UI login form
4 participants