Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signin button): signin button is clickable when token is autofilled by browser #9610

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix(signin button): signin button is clickable when token is autofilled by browser #9610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4946047
fix(signin button): signin button is clickable when token is autofill…
lsq645599166 Oct 29, 2024
4e3004b
fix: fix unit test & using input event instead of change event
lsq645599166 Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/web/src/login/component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe('LoginComponent', () => {
// set inputs and fire change events to trigger onChange()
const token = fixture.debugElement.query(By.css(queries.token)).nativeElement;
token.value = loginToken;
token.dispatchEvent(new Event('keyup'));
token.dispatchEvent(new Event('input'));

submit();

Expand Down
2 changes: 1 addition & 1 deletion modules/web/src/login/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
placeholder="Bearer token"
type="password"
required
(keyup)="onChange($event)"
(input)="onChange($event)"
/>
</mat-form-field>
<mat-error
Expand Down
Loading