-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taint Based Eviction #166
Comments
@davidopp @gmarek @kevin-wangzefeng please, provide us with the release notes and documentation PR (or links) at the features spreadsheet. |
Documentation PR out for review at https://github.com/kubernetes/kubernetes.github.io/pull/2774/files |
Regarding "taint-based eviction for node problems is in Alpha": nobody is available to move it to beta in 1.7, so it will stay in alpha in 1.7. |
@davidopp I can help on this and target for 1.7, one question is that I saw kubernetes/kubernetes#40355 is already enabled by default, so can you please explain more for what do you mean by move this to beta in 1.7? |
@gyliu513 - taint controller is enabled by default, but using taints instead of direct evictions in case of node problems isn't. To move it to beta there's at least one thing to be done (except renaming stuff from alpha to bete), which is to rewrite/write new NodeController unit tests, as they currently assume direct evictions. There are some very basic tests for taint-based evictions, but they should be drastically extended (e.g. cover all master-disruption logic). |
Yes, I can find time for reviews and I can find time to think through what needs to be done, if there's someone willing to work on it. |
assigned |
@gyliu513 OK - let me know if you need some directions. |
Move to Beta is goal for 1.7. |
@gmarek I want to split the work to two tasks:
Comments? |
@skilxn-go I opened a PR to move the KEP here: #1510 |
Thanks, got it |
Hi @damemi, just a friendly reminder that the Code Freeze will go into effect on Thursday 5th March. Can you please link all the k/k PRs or any other PRs which should be tracked for this enhancement? Thank You :) |
Hi @palnabarun, we have an umbrella issue which links to the issues/PRs that are in the works for this: kubernetes/kubernetes#87161 |
Thank you @damemi for updating this. :) |
Hey @damemi - Seth here, Docs shadow on the 1.18 release team. Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so) If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th. Let me know if you have any questions! |
@sethmccombs IIUC, given I have the doc PR opened against dev-1.18 branch (kubernetes/website#19302), there's no need to update any sheet, right? |
@ingvagabund you got it, I'll update the Enhancement tracking sheet! |
Hi @damemi, this a reminder that we are just two days away from Code Freeze on 5th March. By the Code Freeze, all the relevant PR's should be merged else you would need to file an exception request. |
@palnabarun I've updated the 3 PRs that this is waiting on to see if they will merge by code freeze. |
@palnabarun actually before those 3 can merge, we need to get the KEP move approved: #1510 |
@damemi I see that the PR's are blocked on approvals at the moment. Do you think they would make it before the deadline? Today EOD is the Code Freeze Please file an exception if you think the PR's might slip the deadline. |
I think we will need more time to get the approvals, what's the process to file an exception? |
@damemi, you can find the process here https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md |
@jeremyrickard thanks, exception filed |
@damemi The exception request was approved. :) |
Hi @damemi, since this enhancement graduated to Stable this release 🚀, the status can now be set to be Can you please update the status? After that, we will close this issue. |
@palnabarun sure, opened that here: #1625 |
Thank you @damemi :) |
enhancements: support real-time kernels
The corresponding enhancement has graduated to Closing this issue. /close |
@palnabarun: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Edit: The issue description here had a 404 link. Pointed it to the correct one. |
Feature Description
The text was updated successfully, but these errors were encountered: