-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TaintBasedEvictions GA kep from scheduling to node #1510
Conversation
/cc @ahg-g @Huang-Wei |
The approving sig is sig-node so naturally it should be placed under sig-node KEPs. |
Does this need to merge by enhancement freeze (tomorrow)? Technically this KEP already merged and passed the enhancement freeze requirements, it's just under the wrong folder, right? |
Other discussion that this would be better suited under sig-apps: kubernetes/kubernetes#87427 (comment) |
Ok. Got it |
We've decided to keep this under sig-node (kubernetes/kubernetes#87427 (comment)). So, bumping, can this merge? |
Bumping, can this be merged to move the KEP to sig-node? I believe we've reached a consensus at this point that this should be there |
/assign @derekwaynecarr |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, derekwaynecarr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was erroneously merged under sig-scheduling, but it should be under sig-node
See kubernetes/kubernetes#87487 (comment)
/sig node